chore(clerk-js): Keep CreateOrganizationForm disabled if avatar has been uploaded and org name is empty - #1910
Conversation
🦋 Changeset detectedLatest commit: c80dbbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
||
| const dataChanged = !!nameField.value; | ||
| const canSubmit = dataChanged || !!file; | ||
| const canSubmit = dataChanged; |
There was a problem hiding this comment.
Does the avatar get uploaded without submitting the form? Is that why we don't check for it here?
There was a problem hiding this comment.
Also, is there not form.isDirty or something similar in clerk-js?
There was a problem hiding this comment.
We upload the logo, after the org is created (after the submission)
No i don't think we support isDirty out of the box.
|
|
||
| const dataChanged = !!nameField.value; | ||
| const canSubmit = dataChanged || !!file; | ||
| const canSubmit = dataChanged; |
There was a problem hiding this comment.
We upload the logo, after the org is created (after the submission)
No i don't think we support isDirty out of the box.
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
6 participants
Description
In this pr we disable the form of
CreateOrganizationFormwhen avatar has been selected but organization name is empty in order to have the same experience when no avatar has been selectedChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreBefore
Screen.Recording.2023-10-18.at.12.00.38.PM.mov
After
Screen.Recording.2023-10-18.at.12.08.56.PM.mov